Skip to content

Commit ea7bcd1

Browse files
ci: don't fail fast on macos tests #3681
Problem: Usually if one of the macos tests fails, we will abort all other ones. But, recently vs code insiders is failing exclusively and it aborts the other tests even though they should be fine. Due to this we cannot easily see that everything else is passing. Solution: Don't fail fast on mac os tests, let all of them run and maybe we can tell if it is just a vscode insiders problem more easily. Signed-off-by: Nikolas Komonen <[email protected]>
1 parent 75e242d commit ea7bcd1

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.github/workflows/node.js.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ jobs:
1414
name: test macOS
1515
runs-on: macos-latest
1616
strategy:
17+
fail-fast: false
1718
matrix:
1819
node-version: [16.x]
1920
vscode-version: [minimum, stable, insiders]

0 commit comments

Comments
 (0)