delete artifacts

Author: David Hasani

packages/core/src/codewhisperer/models/constants.ts

@@ -806,6 +806,7 @@ export const skipUnitTestsFormTitle = 'Choose to skip unit tests'
 
 export const selectiveTransformationFormTitle = 'Choose how to receive proposed changes'
 
+// TO-DO: get text from Allie for this
 export const skipUnitTestsFormMessage =
     'I will build your project using `mvn clean test` by default. If you would like me to build your project without running unit tests, I will use `mvn clean test-compile`.'
 

packages/core/src/codewhisperer/service/transformByQ/transformApiHandler.ts

@@ -828,17 +828,13 @@ export async function runClientSideBuild(projectCopyPath: string, clientInstruct
         },
     }
     getLogger().info(`CodeTransformation: uploading client build results at ${uploadZipPath} and resuming job now`)
-    await uploadPayload(uploadZipPath, AuthUtil.instance.regionProfileManager.activeRegionProfile, uploadContext)
-    await resumeTransformationJob(transformByQState.getJobId(), 'COMPLETED')
     try {
+        await uploadPayload(uploadZipPath, AuthUtil.instance.regionProfileManager.activeRegionProfile, uploadContext)
+        await resumeTransformationJob(transformByQState.getJobId(), 'COMPLETED')
+    } finally {
         await fs.delete(projectCopyPath, { recursive: true })
         await fs.delete(uploadZipBaseDir, { recursive: true })
-        // TODO: do we need to delete the downloaded client instructions and uploadZipPath?
-        // Check with AppSec, but they can help in debugging
-    } catch {
-        getLogger().error(
-            `CodeTransformation: failed to delete project copy and uploadZipBaseDir after client-side build`
-        )
+        getLogger().info(`CodeTransformation: Just deleted project copy and uploadZipBaseDir after client-side build`)
     }
 }