Skip to content

Commit eba9bf3

Browse files
authored
fix(codewhisperer): Fix duplicate userDecision telemetry accept (#2930)
1 parent 7ea486d commit eba9bf3

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/codewhisperer/commands/onInlineAcceptance.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ export const acceptSuggestion = Commands.declare(
6262
).finally(async () => {
6363
if (isInlineCompletionEnabled()) {
6464
// at the end of recommendation acceptance, clear recommendations.
65+
RecommendationHandler.instance.clearRecommendations()
6566
await InlineCompletionService.instance.clearInlineCompletionStates(editor)
6667
}
6768
})

src/test/codewhisperer/service/completionProvider.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ describe('completionProviderService', function () {
3535
describe('getCompletionItem', function () {
3636
it('should return targetCompletionItem given input', function () {
3737
RecommendationHandler.instance.startPos = new vscode.Position(0, 0)
38+
RecommendationHandler.instance.requestId = 'mock_requestId_getCompletionItem'
39+
RecommendationHandler.instance.sessionId = 'mock_sessionId_getCompletionItem'
3840
const mockPosition = new vscode.Position(0, 1)
3941
const mockRecommendationDetail: Recommendation = {
4042
content: "\n\t\tconsole.log('Hello world!');\n\t}",
@@ -60,8 +62,8 @@ describe('completionProviderService', function () {
6062
new vscode.Range(0, 0, 0, 0),
6163
1,
6264
"\n\t\tconsole.log('Hello world!');\n\t}",
63-
'test',
64-
'test',
65+
'mock_requestId_getCompletionItem',
66+
'mock_sessionId_getCompletionItem',
6567
'OnDemand',
6668
'Line',
6769
'javascript',

0 commit comments

Comments
 (0)