Skip to content

Commit ec360f2

Browse files
committed
fix(amazonq): Auto-trigger review flow on scan button click
1 parent 29c4048 commit ec360f2

File tree

6 files changed

+5
-19
lines changed

6 files changed

+5
-19
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type": "Bug Fix",
3+
"description": "Code review starts automatically when clicking \"Full project scan\" button"
4+
}

packages/amazonq/src/app/amazonqScan/app.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export function init(appContext: AmazonQAppInitContext) {
2525
authClicked: new vscode.EventEmitter<any>(),
2626
tabOpened: new vscode.EventEmitter<any>(),
2727
tabClosed: new vscode.EventEmitter<any>(),
28-
runScan: new vscode.EventEmitter<any>(),
2928
formActionClicked: new vscode.EventEmitter<any>(),
3029
errorThrown: new vscode.EventEmitter<any>(),
3130
showSecurityScan: new vscode.EventEmitter<any>(),

packages/amazonq/src/app/amazonqScan/chat/controller/controller.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export class ScanController {
4848
this.authController = new AuthController()
4949

5050
this.chatControllerMessageListeners.tabOpened.event((data) => {
51-
return this.tabOpened(data)
51+
return this.tabOpened(data).then(() => this.scanInitiated(data))
5252
})
5353

5454
this.chatControllerMessageListeners.tabClosed.event((data) => {
@@ -59,10 +59,6 @@ export class ScanController {
5959
this.authClicked(data)
6060
})
6161

62-
this.chatControllerMessageListeners.runScan.event((data) => {
63-
return this.scanInitiated(data)
64-
})
65-
6662
this.chatControllerMessageListeners.formActionClicked.event((data) => {
6763
return this.formActionClicked(data)
6864
})

packages/amazonq/src/app/amazonqScan/chat/views/actions/uiMessageListener.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ export class UIMessageListener {
4040
case 'auth-follow-up-was-clicked':
4141
this.authClicked(msg)
4242
break
43-
case 'review':
44-
this.scan(msg)
45-
break
4643
case 'form-action-click':
4744
this.formActionClicked(msg)
4845
break
@@ -58,12 +55,6 @@ export class UIMessageListener {
5855
}
5956
}
6057

61-
private scan(msg: UIMessage) {
62-
this.scanControllerEventsEmitters?.runScan.fire({
63-
tabID: msg.tabID,
64-
})
65-
}
66-
6758
private formActionClicked(msg: UIMessage) {
6859
this.scanControllerEventsEmitters?.formActionClicked.fire({
6960
...msg,

packages/core/src/amazonq/webview/ui/connector.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -307,9 +307,6 @@ export class Connector {
307307
case 'doc':
308308
this.docChatConnector.onTabOpen(tabID)
309309
break
310-
case 'review':
311-
this.scanChatConnector.onTabOpen(tabID)
312-
break
313310
}
314311
}
315312

packages/core/src/amazonqScan/controller.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export interface ScanChatControllerEventEmitters {
2020
readonly tabOpened: vscode.EventEmitter<any>
2121
readonly tabClosed: vscode.EventEmitter<any>
2222
readonly authClicked: vscode.EventEmitter<any>
23-
readonly runScan: vscode.EventEmitter<any>
2423
readonly formActionClicked: vscode.EventEmitter<any>
2524
readonly errorThrown: vscode.EventEmitter<any>
2625
readonly showSecurityScan: vscode.EventEmitter<any>

0 commit comments

Comments
 (0)