fix(amazonq): codeSelection incorrect if user has no selection #4921

leigaol · web-flow · commit eca2efe606a4 · 2024-05-02T16:20:27.000-07:00
Problem
Ask Q to write a unit test of a function, Q does not know how to do it. It hallucinates the function.( It does not know which class I am generating against). See internal TT P128119238.

Solution
Let the cursorState.range be undefined if user do not have a selection. The function getSelectionInsideExtendedCodeBlock is supposed to take the original selection as input, not the importantRange (which is current line of cursor)
diff --git a/packages/amazonq/.changes/next-release/Bug Fix-12271e0b-126f-4112-936d-a94ad0566aee.json b/packages/amazonq/.changes/next-release/Bug Fix-12271e0b-126f-4112-936d-a94ad0566aee.json
@@ -0,0 +1,4 @@
+{
+	"type": "Bug Fix",
+	"description": "Fix bug when Amazon Q chat sends code selection while user has no selection"
+}
diff --git a/packages/core/src/codewhispererChat/editor/context/focusArea/focusAreaExtractor.ts b/packages/core/src/codewhispererChat/editor/context/focusArea/focusAreaExtractor.ts
@@ -57,7 +57,7 @@ export class FocusAreaContextExtractor {
             extendedCodeBlock: this.getRangeText(editor.document, extendedCodeBlockRange),
             codeBlock: codeBlock,
             selectionInsideExtendedCodeBlock: this.getSelectionInsideExtendedCodeBlock(
-                importantRange as Selection,
+                editor.selection,
                 extendedCodeBlockRange
             ),
             names:

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +{
 +	"type": "Bug Fix",
 +	"description": "Fix bug when Amazon Q chat sends code selection while user has no selection"
 +}