Commit eed4803
authored
feat(amazonq): Adding diff view UX for generated files in Agentic chat (#6876)
## Problem
- Existing UX accepts the generated files without permission check.
## Solution
- Added code diff view using VSC native diff functionality, Users can
click on the generated files and see the code diff.
- Users can now accept/reject the generated code.
- Close the diff view once user clicks on Accept or Reject.
- Fix: If user clicks on `Confirm` button to execute the bash command
change this to `Confirmed` state.
- In read tool execution and safe bash command execution use different
id: `generic-tool-execution` in processCustomFormAction as this helps
the above step to execute.
- Fix: Removing the Q spinner component if user clicks on reject button
or code diff filePath.
https://github.com/user-attachments/assets/be672101-aed4-4fa7-95d7-6a932d0f95ac
---
- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.1 parent 10bb1c7 commit eed4803
File tree
11 files changed
+259
-200
lines changed- packages/core/src
- amazonq/webview/ui/apps
- codewhispererChat
- clients/chat/v0
- controllers/chat
- messenger
- tools
- test/codewhispererChat/tools
11 files changed
+259
-200
lines changedLines changed: 16 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
264 | 264 | | |
265 | 265 | | |
266 | 266 | | |
267 | | - | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
268 | 271 | | |
269 | 272 | | |
270 | 273 | | |
| |||
297 | 300 | | |
298 | 301 | | |
299 | 302 | | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
300 | 315 | | |
301 | 316 | | |
302 | 317 | | |
| |||
Lines changed: 0 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
24 | 22 | | |
25 | 23 | | |
26 | 24 | | |
27 | | - | |
28 | | - | |
29 | 25 | | |
30 | 26 | | |
31 | 27 | | |
| |||
61 | 57 | | |
62 | 58 | | |
63 | 59 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | 60 | | |
71 | 61 | | |
72 | 62 | | |
73 | 63 | | |
74 | 64 | | |
75 | 65 | | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | 66 | | |
83 | 67 | | |
84 | 68 | | |
| |||
0 commit comments