Skip to content

Commit f004173

Browse files
authored
fix(notifications): dismiss command visible in command palette (#6407)
Gets rid of these ![image](https://github.com/user-attachments/assets/d0afa2c8-c8c5-43d0-82a0-1ea086be5239) You can still dismiss by clicking the X button next to non-emergency notifications. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 825d2fc commit f004173

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type": "Bug Fix",
3+
"description": "Notifications: 'Dismiss' command visible in command palette."
4+
}

packages/amazonq/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@
198198
{
199199
"id": "aws.amazonq.notifications",
200200
"name": "%AWS.notifications.title%",
201-
"when": "!isCloud9 && !aws.isSageMaker && aws.amazonq.notifications.show"
201+
"when": "!(isCloud9 || aws.isSageMaker) && aws.amazonq.notifications.show"
202202
},
203203
{
204204
"type": "webview",
@@ -496,7 +496,7 @@
496496
"command": "_aws.amazonq.notifications.dismiss",
497497
"title": "%AWS.generic.dismiss%",
498498
"category": "%AWS.amazonq.title%",
499-
"enablement": "isCloud9 || !aws.isWebExtHost",
499+
"enablement": "view == aws.amazonq.notifications",
500500
"icon": "$(remove-close)"
501501
},
502502
{
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type": "Bug Fix",
3+
"description": "Notifications: 'Dismiss' command visible in command palette."
4+
}

packages/toolkit/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -732,7 +732,7 @@
732732
{
733733
"id": "aws.toolkit.notifications",
734734
"name": "%AWS.notifications.title%",
735-
"when": "!isCloud9 && !aws.isSageMaker && aws.toolkit.notifications.show"
735+
"when": "!(isCloud9 || aws.isSageMaker) && aws.toolkit.notifications.show"
736736
},
737737
{
738738
"id": "aws.amazonq.codewhisperer",
@@ -2231,7 +2231,7 @@
22312231
"command": "_aws.toolkit.notifications.dismiss",
22322232
"title": "%AWS.generic.dismiss%",
22332233
"category": "%AWS.title%",
2234-
"enablement": "isCloud9 || !aws.isWebExtHost",
2234+
"enablement": "view == aws.toolkit.notifications",
22352235
"icon": "$(remove-close)"
22362236
},
22372237
{

0 commit comments

Comments
 (0)