fix(telemetry): aws_refreshCredentials is passive #2679

justinmk3 · web-flow · commit f1294aa751de · 2022-06-06T12:44:02.000-07:00
This is already done in the callsite: https://github.com/aws/aws-toolkit-vscode/blob/97c6eea010d87ff47798edba08fcc34a6082e559/src/credentials/loginManager.ts#L343 but putting it in the definition helps avoid accidents.
diff --git a/src/shared/telemetry/vscodeTelemetry.json b/src/shared/telemetry/vscodeTelemetry.json
@@ -28,6 +28,7 @@
         {
             "name": "aws_refreshCredentials",
             "description": "Emitted when credentials are automatically refreshed by the AWS SDK",
+            "passive": true,
             "metadata": [
                 {
                     "type": "result"

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@`
`28`	`28`	`{`
`29`	`29`	`"name": "aws_refreshCredentials",`
`30`	`30`	`"description": "Emitted when credentials are automatically refreshed by the AWS SDK",`
	`31`	`+ "passive": true,`
`31`	`32`	`"metadata": [`
`32`	`33`	`{`
`33`	`34`	`"type": "result"`