Merge pull request #1553 from Galaoaoa/fix/ygloa-starling

fix(Starling): make file watcher disposable

Author: Apurva

src/applicationcomposer/composerWebview.ts

@@ -82,6 +82,7 @@ export class ApplicationComposer {
                 handleMessage(message, {
                     panel: panel,
                     textDocument: textDocument,
+                    disposables: this.disposables,
                     workSpacePath: this.workSpacePath,
                     defaultTemplatePath: this.defaultTemplatePath,
                     defaultTemplateName: this.defaultTemplateName,

src/applicationcomposer/messageHandlers/addFileWatchMessageHandler.ts

@@ -23,6 +23,7 @@ export async function addFileWatchMessageHandler(request: AddFileWatchRequestMes
         const filePath = context.defaultTemplatePath
         const fileName = context.defaultTemplateName
         const fileWatch = vscode.workspace.createFileSystemWatcher(filePath)
+        context.disposables.push(fileWatch)
 
         fileWatch.onDidChange(async () => {
             const fileContents = (await vscode.workspace.fs.readFile(vscode.Uri.file(filePath))).toString()

src/applicationcomposer/types.ts

@@ -7,7 +7,7 @@ import * as vscode from 'vscode'
 export type WebviewContext = {
     panel: vscode.WebviewPanel
     textDocument: vscode.TextDocument
-    disposables?: vscode.Disposable[]
+    disposables: vscode.Disposable[]
     workSpacePath: string
     defaultTemplatePath: string
     defaultTemplateName: string