clean up script

Author: Hweinstock

.github/workflows/lintdupe.js

@@ -1,31 +1,28 @@
 const fs = require('fs/promises')
 
+async function getCloneCount(jsonFile) {
+    const result = JSON.parse(await fs.readFile(jsonFile, 'utf8'))
+    return result.statistics.total.clones
+}
+
 async function main() {
     console.log(`In args with: ${process.argv}`)
     const masterJson = process.argv[2]
     const branchJson = process.argv[3]
     console.log(`master report located at ${masterJson}`)
     console.log(`branch report located at ${branchJson}`)
 
-    const masterResult = JSON.parse(await fs.readFile(masterJson, 'utf8'))
-    const branchResult = JSON.parse(await fs.readFile(branchJson, 'utf8'))
-
-    console.log('master')
-    console.log(masterResult)
-    console.log('branch')
-    console.log(branchResult)
-
-    const masterClones = masterResult.statistics.total.clones
-    const branchClones = branchResult.statistics.total.clones
+    const masterClones = await getCloneCount(masterJson)
+    const branchClones = await getCloneCount(branchJson)
 
     console.log(`total clones on master is: ${masterClones}`)
     console.log(`total clones on branch is: ${branchClones}`)
 
     if (masterClones < branchClones) {
-        console.log('introducing new duplicate code!')
+        console.log(`❌ Copy-Paste Test failed, increasing clone count by ${masterClones - branchClones}`)
         process.exit(1)
     } else {
-        console.log('pass')
+        console.log(`✅ Copy-Paste Test passed`)
     }
 }
 

.github/workflows/node.js.yml

@@ -80,8 +80,7 @@ jobs:
                   git checkout ${{ github.ref }}
                   npx jscpd --pattern "packages/**/*.ts" --ignore "**node_modules**,**dist**,**test**" --gitignore --reporters json --output branch
             - name: Compare clone count across master and new branch
-              run: |
-                  node "$GITHUB_WORKSPACE/.github/workflows/lintdupe.js" master/jscpd-report.json branch/jscpd-report.json
+              run: node "$GITHUB_WORKSPACE/.github/workflows/lintdupe.js" master/jscpd-report.json branch/jscpd-report.json
 
     macos:
         needs: lint-commits