chore: Fix PR comments

This fixes PR comments:
- Dont use underscore for private
- Refactor variables to make accepted
  sequences more clear

Signed-off-by: Nikolas Komonen <[email protected]>

Author: nkomonen-amazon

src/shared/sam/cli/samCliInvokerUtils.ts

@@ -66,31 +66,36 @@ export function logAndThrowIfUnexpectedExitCode(processResult: ChildProcessResul
  */
 export function collectAcceptedErrorMessages(errorMessage: string): string[] {
     const errors = errorMessage.split('\n')
-    const shouldCollectFuncs = [_startsWithEscapeSequence, _startsWithError]
+    const shouldCollectFuncs = [startsWithEscapeSequence, startsWithError]
     return errors.filter(error => {
         return shouldCollectFuncs.some(shouldCollect => {
             return shouldCollect(error)
         })
     })
 }
 
+/**
+ * All accepted escape sequences.
+ */
+const yellowForeground = '[33m'
+const acceptedSequences = [yellowForeground]
+
 /**
  * Returns true if text starts with an escape
  * sequence with one of the accepted sequences.
  */
-function _startsWithEscapeSequence(text: string): boolean {
+function startsWithEscapeSequence(text: string, sequences = acceptedSequences): boolean {
     const escapeInDecimal = 27
     if (text.charCodeAt(0) !== escapeInDecimal) {
         return false
     }
 
     const remainingText = text.substring(1)
-    const acceptedSequences = ['[33m']
-    return acceptedSequences.some(code => {
+    return sequences.some(code => {
         return remainingText.startsWith(code)
     })
 }
 
-function _startsWithError(text: string): boolean {
+function startsWithError(text: string): boolean {
     return text.startsWith('Error:')
 }