Skip to content

Commit fbcc2ac

Browse files
committed
skip test on old version
1 parent 74e8ac9 commit fbcc2ac

File tree

2 files changed

+29
-27
lines changed

2 files changed

+29
-27
lines changed

packages/core/src/test/applicationcomposer/messageHandlers/generateResourceHandler.test.ts

Lines changed: 24 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -11,32 +11,29 @@ import { generateResourceHandler } from '../../../applicationcomposer/messageHan
1111
import { Command, MessageType } from '../../../applicationcomposer/types'
1212
import * as env from '../../../shared/vscode/env'
1313

14-
// eslint-disable-next-line aws-toolkits/no-only-in-tests
15-
describe.only('generateResourceHandler', function () {
16-
for (const _ of Array.from({ length: 1000 }, (i) => i)) {
17-
it('amazon q is not installed', async function () {
18-
const version = env.getMinVscodeVersion()
19-
if (semver.lt(version, '1.88.0')) {
20-
this.skip()
21-
}
22-
const panel = await createTemplate()
23-
const postMessageSpy = sinon.spy(panel.webview, 'postMessage')
24-
const context = await createWebviewContext({
25-
panel,
26-
})
27-
await generateResourceHandler(
28-
{
29-
command: Command.GENERATE_RESOURCE,
30-
messageType: MessageType.REQUEST,
31-
cfnType: '',
32-
prompt: '',
33-
traceId: '0',
34-
},
35-
context
36-
)
37-
assert.ok(postMessageSpy.calledOnce)
38-
assert.deepStrictEqual(postMessageSpy.getCall(0).args[0].isSuccess, false)
39-
postMessageSpy.restore()
14+
describe('generateResourceHandler', function () {
15+
it('amazon q is not installed', async function () {
16+
const version = env.getMinVscodeVersion()
17+
if (semver.lt(version, '1.88.0')) {
18+
this.skip()
19+
}
20+
const panel = await createTemplate()
21+
const postMessageSpy = sinon.spy(panel.webview, 'postMessage')
22+
const context = await createWebviewContext({
23+
panel,
4024
})
41-
}
25+
await generateResourceHandler(
26+
{
27+
command: Command.GENERATE_RESOURCE,
28+
messageType: MessageType.REQUEST,
29+
cfnType: '',
30+
prompt: '',
31+
traceId: '0',
32+
},
33+
context
34+
)
35+
assert.ok(postMessageSpy.calledOnce)
36+
assert.deepStrictEqual(postMessageSpy.getCall(0).args[0].isSuccess, false)
37+
postMessageSpy.restore()
38+
})
4239
})

packages/core/src/test/techdebt.test.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,11 @@ describe('tech debt', function () {
2525
semver.lt(minVscode, '1.93.0'),
2626
'keepAlive works properly in vscode 1.93+. Remove src/codewhisperer/client/agent.ts and other code related to https://github.com/aws/aws-toolkit-vscode-staging/pull/1214'
2727
)
28+
29+
assert.ok(
30+
semver.lt(minVscode, '1.88.0'),
31+
'with vscode 1.88, we can remove the check in src/test/applicationcomposer/messageHandlers/generateResourceHandler.test.ts (generateResourceHandler: amazon q is not installed) test'
32+
)
2833
})
2934

3035
it('nodejs minimum version', async function () {

0 commit comments

Comments
 (0)