test: check tech debt for old nodejs versions #2651

When the minimum nodejs is 16+, we can use the `performance` global
always, instead of using `perf_hooks` on nodejs (which doesn't work in
the browser).

Author: justinmk3

src/shared/extensionUtilities.ts

@@ -329,11 +329,7 @@ export function showWelcomeMessage(context: vscode.ExtensionContext): void {
 }
 
 /**
- * Creates a modal to display OS, AWS Toolkit, and VS Code
- * versions and allows user to copy to clipboard
- * Also prints to the toolkit output channel
- *
- * @param toolkitOutputChannel VS Code Output Channel
+ * Shows info about the extension and its environment.
  */
 export async function aboutToolkit(): Promise<void> {
     const toolkitEnvDetails = getToolkitEnvironmentDetails()
@@ -353,16 +349,21 @@ export function getToolkitEnvironmentDetails(): string {
     const osArch = os.arch()
     const osRelease = os.release()
     const vsCodeVersion = vscode.version
+    const node = process.versions.node ? `node: ${process.versions.node}\n` : 'node: ?\n'
+    const electron = process.versions.electron ? `electron: ${process.versions.electron}\n` : ''
+
     const envDetails = localize(
         'AWS.message.toolkitInfo',
-        'OS:  {0} {1} {2}\n{3} Extension Host Version:  {4}\n{5} Toolkit Version:  {6}\n',
+        'OS: {0} {1} {2}\n{3} extension host:  {4}\n{5} Toolkit:  {6}\n{7}{8}',
         osType,
         osArch,
         osRelease,
         getIdeProperties().longName,
         vsCodeVersion,
         getIdeProperties().company,
-        extensionVersion
+        extensionVersion,
+        node,
+        electron
     )
 
     return envDetails

src/shared/vscode/env.ts

@@ -88,3 +88,10 @@ export function isMinimumVersion(): boolean {
 export function getMinVscodeVersion(): string {
     return packageJson.engines.vscode.replace(/[^~]/, '')
 }
+
+/**
+ * Returns the minimum nodejs version declared in `package.json`.
+ */
+export function getMinNodejsVersion(): string {
+    return packageJson.devDependencies['@types/node'].replace(/[^~]/, '')
+}

src/test/techdebt.test.ts

@@ -5,13 +5,13 @@
 
 import * as assert from 'assert'
 import * as semver from 'semver'
-import { getMinVscodeVersion } from '../shared/vscode/env'
+import * as env from '../shared/vscode/env'
 
 // Checks project config and dependencies, to remind us to remove old things
 // when possible.
 describe('tech debt', function () {
     it('vscode minimum version', async function () {
-        const minVscode = getMinVscodeVersion()
+        const minVscode = env.getMinVscodeVersion()
 
         assert.ok(
             semver.lt(minVscode, '1.53.0'),
@@ -23,4 +23,18 @@ describe('tech debt', function () {
             'remove filesystemUtilities.findFile(), use vscode.workspace.findFiles() instead'
         )
     })
+
+    it('nodejs minimum version', async function () {
+        const minNodejs = env.getMinNodejsVersion()
+
+        assert.ok(
+            semver.lt(minNodejs, '16.0.0'),
+            'remove require("perf_hooks").performance workarounds, use globalThis.performance instead (always available since nodejs 16.x)'
+        )
+
+        assert.ok(
+            semver.lt(minNodejs, '16.0.0'),
+            'with node16+, we can now use AbortController to cancel Node things (child processes, HTTP requests, etc.)'
+        )
+    })
 })