add timeout to child process

Author: Hweinstock

packages/core/src/awsService/ec2/sshKeyPair.ts

@@ -80,6 +80,7 @@ export class SshKeyPair {
         }
         return !(await tryRun('ssh-keygen', ['-t', keyType, '-N', '', '-q', '-f', keyPath], 'yes', 'unknown key type', {
             onStdout: overrideKeys,
+            timeout: new Timeout(3000),
         }))
     }
 

packages/core/src/shared/utilities/pathFind.ts

@@ -11,7 +11,6 @@ import { GitExtension } from '../extensions/git'
 import { Settings } from '../settings'
 import { getLogger } from '../logger/logger'
 import { mergeResolvedShellPath } from '../env/resolveEnv'
-import { Timeout } from './timeoutUtils'
 
 /** Full path to VSCode CLI. */
 let vscPath: string
@@ -33,13 +32,9 @@ export async function tryRun(
     p: string,
     args: string[],
     logging: 'yes' | 'no' | 'noresult' = 'yes',
-    timeout?: Timeout,
     expected?: string,
     opt?: ChildProcessOptions
 ): Promise<boolean> {
-    timeout?.onCompletion(() => {
-        throw new Error(`tryRun timed out: ${p} ${args.join(' ')}`)
-    })
     const proc = new ChildProcess(p, args, { logging: 'no' })
     const r = await proc.run({
         ...opt,