Skip to content

Commit ff6dca6

Browse files
committed
fix: circular import for "replaceVscodeVars"
1 parent 183e0e4 commit ff6dca6

File tree

4 files changed

+13
-14
lines changed

4 files changed

+13
-14
lines changed

src/lambda/commands/createNewSamApp.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import { addFolderToWorkspace, tryGetAbsolutePath } from '../../shared/utilities
3232
import { goRuntimes } from '../models/samLambdaRuntime'
3333
import { eventBridgeStarterAppTemplate } from '../models/samTemplates'
3434
import { CreateNewSamAppWizard, CreateNewSamAppWizardForm } from '../wizards/samInitWizard'
35-
import { LaunchConfiguration, replaceVscodeVars } from '../../shared/debug/launchConfiguration'
35+
import { LaunchConfiguration } from '../../shared/debug/launchConfiguration'
3636
import { SamDebugConfigProvider } from '../../shared/sam/debugger/awsSamDebugger'
3737
import { ExtContext } from '../../shared/extensions'
3838
import { isTemplateTargetProperties } from '../../shared/sam/debugger/awsSamDebugConfiguration'
@@ -48,7 +48,7 @@ import globals from '../../shared/extensionGlobals'
4848
import { telemetry } from '../../shared/telemetry/telemetry'
4949
import { LambdaArchitecture, Result, Runtime } from '../../shared/telemetry/telemetry'
5050
import { getTelemetryReason, getTelemetryResult } from '../../shared/errors'
51-
import { openUrl } from '../../shared/utilities/vsCodeUtils'
51+
import { openUrl, replaceVscodeVars } from '../../shared/utilities/vsCodeUtils'
5252

5353
export const samInitTemplateFiles: string[] = ['template.yaml', 'template.yml']
5454
export const samInitReadmeFile: string = 'README.TOOLKIT.md'

src/shared/debug/launchConfiguration.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -204,13 +204,3 @@ export async function getReferencedHandlerPaths(launchConfig: LaunchConfiguratio
204204
.thru(array => new Set(array))
205205
.value()
206206
}
207-
208-
/**
209-
* Replaces magic vscode variables in a launch config value.
210-
*/
211-
export function replaceVscodeVars(val: string, workspaceFolder?: string): string {
212-
if (!workspaceFolder) {
213-
return val
214-
}
215-
return val.replace('${workspaceFolder}', workspaceFolder)
216-
}

src/shared/sam/debugger/awsSamDebugConfigurationValidator.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import * as fs from 'fs'
88
import * as path from 'path'
99
import { samImageLambdaRuntimes, samZipLambdaRuntimes } from '../../../lambda/models/samLambdaRuntime'
1010
import * as CloudFormation from '../../cloudformation/cloudformation'
11-
import { localize } from '../../utilities/vsCodeUtils'
11+
import { localize, replaceVscodeVars } from '../../utilities/vsCodeUtils'
1212
import {
1313
awsSamDebugRequestTypes,
1414
awsSamDebugTargetTypes,
@@ -20,7 +20,6 @@ import {
2020
} from './awsSamDebugConfiguration'
2121
import { tryGetAbsolutePath } from '../../utilities/workspaceUtils'
2222
import { CloudFormationTemplateRegistry } from '../../fs/templateRegistry'
23-
import { replaceVscodeVars } from '../../debug/launchConfiguration'
2423

2524
export interface ValidationResult {
2625
isValid: boolean

src/shared/utilities/vsCodeUtils.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,3 +231,13 @@ export async function openUrl(url: vscode.Uri): Promise<boolean> {
231231
export function isToolkitActive(): boolean {
232232
return isExtensionActive(VSCODE_EXTENSION_ID.awstoolkit)
233233
}
234+
235+
/**
236+
* Replaces magic vscode variables in a (launch config) user value.
237+
*/
238+
export function replaceVscodeVars(val: string, workspaceFolder?: string): string {
239+
if (!workspaceFolder) {
240+
return val
241+
}
242+
return val.replace('${workspaceFolder}', workspaceFolder)
243+
}

0 commit comments

Comments
 (0)