CloudFormation formatter does not respect chosen indentation

[lionello]

aws-toolkit-vscode/packages/core/src/awsService/cloudformation/commands/cfnCommands.ts

Line 343 in 22be937

const tabSize = config.get<number>('tabSize', 2)

This is hardcoded to 2 regardless of the indentation chosen in the VSCode editor.

Expected

When I pick a certain indentation in VSCode, I expect the formatter to respect it.

Actual

When formatting CloudFormation YAML file, the items are reindented using a "tab" size of 2, even when I selected indentation size 4. When I have all my CloudFormation YAMLs with a certain indentation size, enabling this VSCode extension certainly changes the entire file, forcing me to enable/disable the extension to avoid unnecessary churn on files.

[atennak1]

Thanks for opening this issue @lionello . What is/was the value of your editor.detectIndentation setting?

Unfortunately the document level indentation setting (your screenshot), isn't conveyed to our language server via LSP, so we make do with our own dectection mechanism, but only if the editor.detectIdentation setting is set to true.