Skip to content

Conversation

@Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Oct 2, 2024

Problem

Continuation of work here: #5670

Solution

In this case downloadExportResultArchieve is reading a large collection of objects into a buffer, then writing that buffer to a file. We test this with varying collections of objects. We test 1x1KB, 10x100B, 100x10B, and 1000x1B.


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock
Copy link
Contributor Author

/retryBuilds

@Hweinstock Hweinstock marked this pull request as ready for review October 4, 2024 14:19
@Hweinstock Hweinstock requested a review from a team as a code owner October 4, 2024 14:19
@Hweinstock
Copy link
Contributor Author

Do not merge until moved (see more #5735)

Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testInteg/perf/ ?

@Hweinstock Hweinstock merged commit 58a2b18 into aws:master Oct 14, 2024
23 of 24 checks passed
@Hweinstock Hweinstock deleted the pTests/downloadAndExtract branch October 14, 2024 21:31
tverney pushed a commit to tverney/aws-toolkit-vscode that referenced this pull request Oct 21, 2024
…hieve. (aws#5710)

## Problem
Continuation of work here:
aws#5670

## Solution
In this case `downloadExportResultArchieve` is reading a large
collection of objects into a buffer, then writing that buffer to a file.
We test this with varying collections of objects. We test 1x1KB,
10x100B, 100x10B, and 1000x1B.

---

<!--- REMINDER: Ensure that your PR meets the guidelines in
CONTRIBUTING.md -->

License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants