Skip to content

test(amazonq): performance test for hashing file in LSP. #5720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 14, 2024
Merged

test(amazonq): performance test for hashing file in LSP. #5720

merged 6 commits into from
Oct 14, 2024

Conversation

@Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Oct 3, 2024 •
edited
Loading

Problem

continuation of performance test work: #5670

Solution

same as previous.
CPU threshold set very high because it spikes pretty wildly on this one.
image

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock Hweinstock marked this pull request as ready for review October 4, 2024 14:18
@Hweinstock Hweinstock requested a review from a team as a code owner October 4, 2024 14:18
@Hweinstock
Copy link
Contributor Author

Hweinstock commented Oct 14, 2024

Do not merge until moved (see more #5735)

justinmk3
justinmk3 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testInteg/perf/

@Hweinstock Hweinstock merged commit e5b5545 into aws:master Oct 14, 2024
22 of 24 checks passed
@Hweinstock Hweinstock deleted the pTests/getFileSha384 branch October 14, 2024 21:27
tverney pushed a commit to tverney/aws-toolkit-vscode that referenced this pull request Oct 21, 2024
@Hweinstock @tverney
test(amazonq): performance test for hashing file in LSP. (aws#5720)
eedbda2 
## Problem
continuation of performance test work:
aws#5670

## Solution
same as previous.
CPU threshold set very high because it spikes pretty wildly on this one.

![image](https://github.com/user-attachments/assets/cc8a6ce9-1be1-4504-b4de-cbafd1241016)


---

<!--- REMINDER: Ensure that your PR meets the guidelines in
CONTRIBUTING.md -->

License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@justinmk3 justinmk3 justinmk3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hweinstock @justinmk3