Skip to content

config(amazonq): update crossfile config and increase each line in a code chunk from 10 to 50 #5739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2024
Merged

config(amazonq): update crossfile config and increase each line in a code chunk from 10 to 50 #5739

merged 5 commits into from
Oct 9, 2024

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Oct 7, 2024 •
edited
Loading

Problem

number of lines per chunk: 10 -> 50

Solution

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested review from a team as code owners October 7, 2024 23:27
@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented Oct 9, 2024

think failing test is not related to this PR

2636 passing (5m)
13 pending
1 failing

  1. Auth
    promptForConnection
    reauthenticates a connection if the user selects an expired one:

    AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

assert_1.default.ok(!refreshedConnItem.description?.match(/expired/i))

  + expected - actual

  -false
  +true
  
  at /Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/packages/core/src/test/credentials/auth.test.ts:595:24
  at runMicrotasks (<anonymous>)
  at processTicksAndRejections (node:internal/process/task_queues:96:5)
  at async /Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/packages/core/src/test/shared/vscode/window.ts:501:29

@nkomonen-amazon
Copy link
Contributor

nkomonen-amazon commented Oct 9, 2024

/retryBuilds

@justinmk3 justinmk3 merged commit 31493a6 into aws:master Oct 9, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewyuq andrewyuq andrewyuq approved these changes

@justinmk3 justinmk3 Awaiting requested review from justinmk3

@jpinkney-aws jpinkney-aws Awaiting requested review from jpinkney-aws

@hayemaxi hayemaxi Awaiting requested review from hayemaxi

+1 more reviewer

@nkomonen-amazon nkomonen-amazon nkomonen-amazon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Will-ShaoHua @nkomonen-amazon @andrewyuq @justinmk3