deps(vscode): temporarily de-bump min back to 1.68.0

[Hweinstock]

Problem

temporarily undo most of: #5704

Solution

• To re-bump we need to add changelog items, otherwise all work remains.
• Considering adding a button to link to vscode download page, but thats an external link we don't control so holding off for now.
• Without running it in the vsix, we have "null extension" in source field:

• Notification in toolkit and Q:

Steps to re-bump to 1.83.0

• update vscode version in all package.json files.
• add breaking fix changelog items in both extensions.

To-do: retest with vsix to make sure null source is gone.

---

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

[github-actions]

This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

[hayemaxi]

Do we need duplicate code?
AFAIK the null extension bug only impacts when running the extension in debug mode and not when its packaged into a vsix.

[Hweinstock]

Ah, not aware of that. I can remove the duplicate code in that case.

[hayemaxi]

Will this ever run? Its always set to false on line 111.
Also it seems its only called once on activation anyways. This seems like more code than we need.

[Hweinstock]

I honestly wasn't sure, but I was using this as an example:

aws-toolkit-vscode/packages/amazonq/src/app/chat/activation.ts

Lines 77 to 107 in 7d6a975

	async function setupAuthNotification() {
	let notificationDisplayed = false // Auth Notification should be displayed only once.
	await tryShowNotification()
	async function tryShowNotification() {
	// Do not show the notification if the IDE starts and user is already authenticated.
	if (AuthUtil.instance.isConnected()) {
	notificationDisplayed = true
	}
	if (notificationDisplayed) {
	return
	}
	const source = 'authNotification'
	const buttonAction = 'Sign In'
	notificationDisplayed = true
	telemetry.toolkit_showNotification.emit({
	component: 'editor',
	id: source,
	reason: 'notLoggedIn',
	result: 'Succeeded',
	})
	const selection = await vscode.window.showWarningMessage('Start using Amazon Q', buttonAction)
	if (selection === buttonAction) {
	void amazonq.focusAmazonQPanel.execute(placeholder, source)
	}
	}
	}

and left it in to be safe.

[hayemaxi]

That example sorta makes sense because the state of notificationDisplayed can change after its initialized but before evaluation. But regardless it is a such a confusing and unnecessary way to evaluate the message. IMO we should refactor that.

[justinmk3]

Oh darn, I should have mentioned I was working on this, see #5749 which also uses PromptSettings to store a "don't show again"

[justinmk3]

seems like we should have a vscode.window.* wrapper in shared/utilities/messages.ts that emits this (maybe optional by a boolean flag). #5762

[justinmk3]

#5749 has PromptSettings + tests so let's continue with that.