Skip to content

Conversation

@nkomonen-amazon
Copy link
Contributor

Problem

If on an older version the gear icon to set the log level did not exist.

Solution

Prompt user to update vs code if it is missing


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nkomonen-amazon nkomonen-amazon requested a review from a team as a code owner October 10, 2024 19:40
@justinmk3
Copy link
Contributor

justinmk3 commented Oct 10, 2024

This isn't necessary because we now require vscode 1.83. And for any non-release we should perhaps aggressively show a "update vscode" warning if vscode is even a few versions behind.

It's definitely good to write things down, but where possible we want to check stuff programmatically and keep the docs as high-signal as possible.

@justinmk3 justinmk3 closed this Oct 10, 2024
@justinmk3 justinmk3 deleted the nkomonen-amazon-patch-1 branch October 10, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants