refactor(cwl): lift TailLogGroupWizard into its own class #5785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
ivikash
approved these changes
Oct 15, 2024
Contributor
|
Please review https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#pull-request-title . Seems clear that In the future please choose a useful type from https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#pull-request-title , this helps reviewers and automation. |
justinmk3
changed the title
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem Wizard code intermixed with command logic ## Solution Refactor out the Wizard so the TailLogGroup command class can focus only on command logic. * Additionally adds the AWSToolkit for VSCode UserAgent to the CWL LiveTail client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Wizard code intermixed with command logic
Solution
Refactor out the Wizard so the TailLogGroup command class can focus only on command logic.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.