deps(ci node): update node in ci to 18.x [WIP] #5810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hweinstock
changed the title
Contributor
Author
|
Tried bumping the vscode/electron-test version due to failing windows tests, but perhaps its unrelated. I'll continue to investigate. |
Hweinstock
changed the title
justinmk3
reviewed
Oct 21, 2024
Co-authored-by: Justin M. Keyes <[email protected]>
justinmk3
approved these changes
Oct 22, 2024
Contributor
There was a problem hiding this comment.
Nice!
We need to pass
{ shell: true }to avoid error on windows. see more here: https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2
related: #5292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's no real reason we need to use node 16 in CI, and it's preventing us from using some features.
Our tests run against vscode's own version of node, which is unrelated to the node we use to run scripts, etc. (See also: #5761 )
Solution
update CI runners to node 18 instead of 16.
We need to pass
{ shell: true }to avoid error on windows. see more here: https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2License: I confirm that my contribution is made under the terms of the Apache 2.0 license.