telemetry(bug): sessionId not unique #5845
Merged
+118
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkomonen-amazon
changed the title
nkomonen-amazon
force-pushed
the
sessionEndFix
branch
3 times, most recently
from
d386426 to
800b6a5
Compare
Problem: There seems to be a bug with vscode.env.sessionId since we observed in telemetry multiple clientIds who has the same sessionId. Solution: Generate our own sessionId and share it between extensions through globalThis Signed-off-by: nkomonen-amazon <[email protected]>
nkomonen-amazon
force-pushed
the
sessionEndFix
branch
from
800b6a5 to
1c1ab0e
Compare
nkomonen-amazon
commented
Oct 24, 2024
| * on selection. There is no support for name-spacing. Just add the relevant | ||
| * feature/module as a description so it can be moved around easier. | ||
| */ | ||
| const menuOptions: Record<DevFunction, MenuOption> = { |
Contributor
Author
There was a problem hiding this comment.
This was defined at extension load and called getSessionId() before globals was defined. So we just make this a function so it is created once needed
hayemaxi
reviewed
Oct 24, 2024
hayemaxi
approved these changes
Oct 24, 2024
Co-authored-by: Maxim Hayes <[email protected]>
jpinkney-aws
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
There seems to be a bug with vscode.env.sessionId since we observed in telemetry multiple clientIds who had the same sessionId.
Solution:
Generate our own sessionId and share it between extensions through globalThis
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.