build(lint): throw error when number of extra args doesn't match the number of format specifiers in logger.

[Hweinstock]

Builds off of:
#5878

Problem

currently logger.error(msg, err) silently drops err if it doesn't map to a %x format specifier in msg.
we want to either prevent that mistake, or enhance our logger so that it prints useful parts of err instead of silently dropping it.

Also, there are cases like:
getLogger().error('Certificate path {0} already exists', certPath), but this silently drops the arg certPath. Pretty sure this syntax is from Java IIRC and not supported by Node.

Solution

Provide a custom lint rule to ensure the number of extra args matches the number of format specifiers.

Note About Alternatives

• As an alternative, we could have transformed the extra meta items to strings and appended them to the log message or add them as separate log messages. This would allow usage of the form getLogger().error('hit error', e).
• If we add separate log messages, we break the expectation that each logger.error statement corresponds to one message in the log.
• Conversely, if we append to the log message, this is somewhat of a hidden feature not exposed to the consumer. By forcing them to add a '%O' format specifier, we are making them clearly aware of how the error (or other object) will show up in the log, ensuring the effect does not "surprise" the user.

Notes

Relevant: code used to format errors:

aws-toolkit-vscode/packages/core/src/shared/errors.ts

Lines 329 to 334 in f806ae0

	export function formatError(err: Error): string {
	const code = hasCode(err) && err.code !== err.name ? `[${err.code}]` : undefined
	const parts = [`${err.name}:`, getErrorMsg(err), code, formatDetails(err)]
	return parts.filter(isNonNullable).join(' ')
	}

which should now actually be used since errors won't be dropped.

• JSCPD is failing due to some duplicates in the files touched. (none introduced here).

---

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

[jpinkney-aws]

It looks like theres a couple more linting that fail at the bottom of this PR as well

[justinmk3]

Does the log literally contain a "%O" string? If so, that seems like a bug.

[Hweinstock]

Yes, but believe it is only because we are in the TestLogger, which adds the raw strings to an array. (https://github.com/aws/aws-toolkit-vscode/blob/b2ebc10342f63ac95cd3055393e715cb369ec450/packages/core/src/test/testLogger.ts)