feat(lambda): Lambda Getting Started project #5902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1662) * Local invoke and debug webview changes
* Add metrics for deploy and sync
## Problem No hint to add credential in walkthrough "use template in workspace" doesn't recognize `template.yml` ## Solution - Added Credential button in walkthrough - Added Sam Version checker, when customer has version < 1.98, install sam will prompt customer to update their sam version - Fixed "use template in workspace" to search for template.yml as well - Added Fetching template from serverlessland. Now the first two option for init project will work - Modified serverlessland fetcher, added an param `removeTopDir` to remove the top level directory of the zip file. - Added telemetry for walkthrough commands - Update imaging of Walkthough
## Problem AppBuilder doesn't parse sam project in subfolder Welcome view doesn't come back if we closed all folder in workspace ## Solution modified AppBuilder to parse subfolder modified welcome view to re-appear in empty nodes --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…1681) ## Problem SAM list/deploy/remote not picking up toolkit credentials Fix follow bugs: Bug: Deploy Shows weird error without any information if toolkit has not logged in Bug: No such file or directory: 'isengardcli' ## Solution Added credential to environment of childprocess --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Problem The path used to display the resources in the Workspace was according to MacOS standard, leading to not displaying any resources for Windows. Have corrected the path so that it works for both MacOS and Windows. ## Solution Fix on windows
## Problem 1. fix: Runtime property node says “Runtime: undefined” even though template has dotnet6 as runtime 2. fix: If I build with "use defaults" option and I don't have a samconfig file, I don't see the "use_container=true" value in the samconfig when it gets created 3. Rename build quickpickItem label to 'Use default values' ## Solution
## Problem two v3 client are not using toolkit credentials ## Solution Add toolkit credential to v3 client
…it-vscode-staging into autoMerge/feature/lambda-get-started
Merge staging into feature/lambda-get-started
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
justinmk3
changed the title
justinmk3
reviewed
Oct 30, 2024
justinmk3
reviewed
Oct 30, 2024
| * Activates the AWS Explorer UI and related functionality. | ||
| * | ||
| * IMPORTANT: Views that should work in all vscode environments (node or web) | ||
| * should be setup in {@link activateViewsShared}. |
Contributor
There was a problem hiding this comment.
was this comment just copy-paste, or is it actually relevant here?
justinmk3
reviewed
Oct 30, 2024
| import { getLogger } from '../../../shared/logger/logger' | ||
| import { getProjectRootUri } from '../../../shared/sam/utils' | ||
|
|
||
| export async function detectSamProjects(): Promise<SamAppLocation[]> { |
Contributor
There was a problem hiding this comment.
why is this file in /explorer/ ? seems relevant in the /sam/ family of modules.
Contributor
Author
There was a problem hiding this comment.
It's used exclusively to populate the app builder view if a SAM project was detected in the workspace so I believe that's why we have it here. We can track moving this as a fast follow after launch.
justinmk3
reviewed
Oct 30, 2024
justinmk3
reviewed
Oct 30, 2024
packages/toolkit/.changes/next-release/Feature-336a5c62-92cc-4e73-a375-d63eaddb9cc6.json
Outdated
Show resolved
Hide resolved
justinmk3
approved these changes
Oct 30, 2024
Contributor
justinmk3
left a comment
justinmk3
left a comment
There was a problem hiding this comment.
the core/package.json comment is a blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is difficult for new users to get started using their local IDE to build Lambda applications.
Solution
Implemented new section "Application Builder" that adds quick action icons to build, locally invoke, and deploy/sync. Also added a guided walkthrough to offer starter templates and quick installation of prereqs.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.