Skip to content

fix(lambda): remove template path from sam deploy command #5912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2024
+4 −12
Merged

fix(lambda): remove template path from sam deploy command #5912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff304f7
fix(lambda): remove template path from sam deploy command
vicheey Nov 1, 2024
604b211
add info to change log
vicheey Nov 1, 2024
654c2fc
revert manual update to CHANGELOG.md
vicheey Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/core/src/shared/sam/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,10 +377,6 @@ export async function runDeploy(arg: any, wizardParams?: DeployParams): Promise<
throw ToolkitError.chain(error, 'Failed to build SAM template', { details: { ...buildFlags } })
}

// Pass built template to deployFlags
const templatePath = vscode.Uri.joinPath(params.projectRoot, '.aws-sam', 'build', 'template.yaml').fsPath
deployFlags.push('--template-file', `${templatePath}`)

// Create a child process to run the SAM deploy command
const deployProcess = new ChildProcess(samCliPath, ['deploy', ...deployFlags], {
spawnOptions: await addTelemetryEnvVar({
Expand Down
6 changes: 0 additions & 6 deletions packages/core/src/test/shared/sam/deploy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,8 +709,6 @@ describe('SAM Deploy', () => {
'--parameter-overrides',
`ParameterKey=SourceBucketName,ParameterValue=${mockDeployParams.SourceBucketName} ` +
`ParameterKey=DestinationBucketName,ParameterValue=${mockDeployParams.DestinationBucketName}`,
'--template-file',
vscode.Uri.joinPath(projectRoot, '.aws-sam', 'build', 'template.yaml').fsPath,
],
{
spawnOptions: {
Expand Down Expand Up @@ -787,8 +785,6 @@ describe('SAM Deploy', () => {
'--parameter-overrides',
`ParameterKey=SourceBucketName,ParameterValue=${mockDeployParams.SourceBucketName} ` +
`ParameterKey=DestinationBucketName,ParameterValue=${mockDeployParams.DestinationBucketName}`,
'--template-file',
vscode.Uri.joinPath(projectRoot, '.aws-sam', 'build', 'template.yaml').fsPath,
],
{
spawnOptions: {
Expand Down Expand Up @@ -867,8 +863,6 @@ describe('SAM Deploy', () => {
'--parameter-overrides',
`ParameterKey=SourceBucketName,ParameterValue=${mockDeployParams.SourceBucketName} ` +
`ParameterKey=DestinationBucketName,ParameterValue=${mockDeployParams.DestinationBucketName}`,
'--template-file',
vscode.Uri.joinPath(projectRoot, '.aws-sam', 'build', 'template.yaml').fsPath,
],
{
spawnOptions: {
Expand Down
2 changes: 0 additions & 2 deletions packages/core/src/testInteg/sam.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,8 +883,6 @@ describe('SAM Integration Tests', async function () {
'--capabilities',
'CAPABILITY_IAM',
'CAPABILITY_NAMED_IAM',
'--template-file',
vscode.Uri.joinPath(mockDeployParams.projectRoot, '.aws-sam', 'build', 'template.yaml').fsPath,
])

// Check that runInTerminal is called with the correct arguments for deploy
Expand Down
4 changes: 4 additions & 0 deletions packages/toolkit/.changes/next-release/Bug Fix-1ade44c5-bd1f-4b8f-a7f3-f2740ebb8097.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "SAM: Save SAM deploy parameters to correct samconfig.toml in project folder"
}
Loading