refactor(amazonq): add BaseConnector Abstract class for common logic #5931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jpinkney-aws
reviewed
Nov 5, 2024
| /** | ||
| * We've pressed on a followup button and should start watching that round trip telemetry | ||
| */ | ||
| this.sendMessageToExtension({ |
Contributor
There was a problem hiding this comment.
I'd probably move these out of here for now and into the cwchatconnector. I haven't checked whether or not the entire chat round trip telemetry flow works for gumby/feature dev yet
Member
Author
There was a problem hiding this comment.
Discussed Offline - amazonq_chatRoundTrip is not getting emitted for /dev, so this is good to go.
justinmk3
reviewed
Nov 5, 2024
Contributor
There was a problem hiding this comment.
file name should be camelcase (baseConnector.ts)
justinmk3
approved these changes
Nov 5, 2024
Contributor
justinmk3
left a comment
justinmk3
left a comment
There was a problem hiding this comment.
Nice! Are there any tests that could be de-duplicated too?
ivikash
force-pushed
the
refactor/base-connector
branch
from
b364a52 to
7c53a67
Compare
ivikash
force-pushed
the
refactor/base-connector
branch
from
7c53a67 to
5677737
Compare
jpinkney-aws
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an abstract class that can be used by all connectors.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.