Skip to content

feat(amazonq): add new languages for auto scan #5934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

feat(amazonq): add new languages for auto scan #5934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/amazonq/.changes/next-release/Feature-79cd3c68-8432-44b5-a004-dd98b8e858d8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Feature",
"description": "Security Scan: Auto-scan now supports JSX, TSX, Kotlin, Scala, and Shell files."
}
15 changes: 10 additions & 5 deletions packages/amazonq/test/unit/codewhisperer/util/securityScanLanguageContext.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,20 @@ describe('securityScanLanguageContext', function () {
['javascript', true],
['typescript', true],
['jsx', false],
['javascriptreact', false],
['typescriptreact', false],
['javascriptreact', true],
['typescriptreact', true],
['tsx', false],
['csharp', true],
['python', true],
['c', true],
['cpp', true],
['go', true],
['kotlin', false],
['kotlin', true],
['php', true],
['ruby', true],
['rust', false],
['scala', false],
['shellscript', false],
['scala', true],
['shellscript', true],
['sql', false],
['json', true],
['yaml', true],
Expand Down Expand Up @@ -92,7 +92,9 @@ describe('securityScanLanguageContext', function () {
['java', 'java'],
['python', 'python'],
['javascript', 'javascript'],
['javascriptreact', 'javascript'],
['typescript', 'typescript'],
['typescriptreact', 'typescript'],
['csharp', 'csharp'],
['go', 'go'],
['ruby', 'ruby'],
Expand All @@ -112,6 +114,9 @@ describe('securityScanLanguageContext', function () {
['java-properties', 'plaintext'],
['go.mod', 'plaintext'],
['go.sum', 'plaintext'],
['kotlin', 'kotlin'],
['scala', 'scala'],
['shellscript', 'shell'],
]

for (const [securityScanLanguageId, expectedCwsprLanguageId] of securityScanLanguageIds) {
Expand Down
7 changes: 7 additions & 0 deletions packages/core/src/codewhisperer/models/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,9 @@ export const securityScanLanguageIds = [
'java',
'python',
'javascript',
'javascriptreact',
'typescript',
'typescriptreact',
'csharp',
'go',
'ruby',
Expand All @@ -286,6 +288,11 @@ export const securityScanLanguageIds = [
'java-properties',
'go.mod',
'go.sum',
'kotlin',
'scala',
'sh',
'shell',
'shellscript',
] as const

export type SecurityScanLanguageId = (typeof securityScanLanguageIds)[number]
Expand Down
7 changes: 7 additions & 0 deletions packages/core/src/codewhisperer/util/securityScanLanguageContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ export class SecurityScanLanguageContext {
java: 'java',
python: 'python',
javascript: 'javascript',
javascriptreact: 'javascript',
typescript: 'typescript',
typescriptreact: 'typescript',
csharp: 'csharp',
go: 'go',
golang: 'go',
Expand All @@ -40,6 +42,11 @@ export class SecurityScanLanguageContext {
'java-properties': 'plaintext',
'go.mod': 'plaintext',
'go.sum': 'plaintext',
kotlin: 'kotlin',
scala: 'scala',
sh: 'shell',
shell: 'shell',
shellscript: 'shell',
})
}

Expand Down
Loading