refactor(logging): cleanup #5937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpinkney-aws
approved these changes
Nov 6, 2024
ivikash
approved these changes
Nov 6, 2024
justinmk3
force-pushed
the
logtopic
branch
2 times, most recently
from
50ad8dc to
2c33778
Compare
- deduplicate tests - define setTopic on `BaseLogger`, not `ToolkitLogger` - it's not specific to ToolkitLogger, so it should live in the base interface. - define `LogTopic` in `logger.ts`, not `ToolkitLogger` - it's not specific to ToolkitLogger, so it should live in the base interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setTopiconBaseLogger, notToolkitLoggerLogTopicinlogger.ts, notToolkitLoggerLicense: I confirm that my contribution is made under the terms of the Apache 2.0 license.