telemetry(amazonq): Add more information for outlier chat round trips #5944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| duration: totalDuration, | ||
| result: 'Succeeded', | ||
| traceId: metrics.traceId, | ||
| ...(reasonDesc !== undefined ? { reasonDesc } : {}), |
Contributor
There was a problem hiding this comment.
I'm pretty sure that if reasonDesc is undefined it just gets dropped. So would reasonDesc: reasonDesc work?
Contributor
Author
There was a problem hiding this comment.
We want it to be undefined so that we don't send information when its not needed
nkomonen-amazon
approved these changes
Nov 7, 2024
justinmk3
approved these changes
Nov 7, 2024
Contributor
|
Linux CI failures are unrelated. Tracked by: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's hard to diagnose why we sometimes get some extreme values for a chat round trip. One idea is that some remote instances might be hosted in a different region and that's causing the increased values in some rare instances
Solution
Add the stringified version to the reasonDesc field temporarily so that we can get more information. This would look like:
Additional info
The numbers picked were pretty arbitrary
(x > 30000 || x < -30000)but it should give us a sampling of 50+ examples in the next week. After that we can revert this code since we should have all the data we need to see if this is the issue