test(appcomposer): fix initMessageHandler flaky test. #5973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hweinstock
changed the title
Hweinstock
changed the title
justinmk3
reviewed
Nov 11, 2024
packages/core/src/test/applicationcomposer/messageHandlers/generateResourceHandler.test.ts
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
Nov 11, 2024
packages/core/src/test/testUtil.ts
Outdated
Comment on lines
639
to
640
| export function disableIfVscodeBelow(testContext: Mocha.Context, version: string) { | ||
| if (isMinVscode(version)) { |
Contributor
There was a problem hiding this comment.
This isn't really correct. isMinVscode checks if the current vscode is the min version.
The version arg is only relevant for when we bump the min version. It's unrelated to the check itself.
Contributor
There was a problem hiding this comment.
isMinVscode might be less confusing if we change its argument to be dict-like:
if (isMinVscode({ throwIfMinGte = version })
Contributor
Author
There was a problem hiding this comment.
Good catch, I was assuming this cutoff version could only be below the stable/insider versions, which isn't correct. I went ahead and avoided using isMinVscode altogether so that this function can be used more generally.
justinmk3
reviewed
Nov 12, 2024
packages/core/src/test/applicationcomposer/messageHandlers/initMessageHandler.test.ts
Show resolved
Hide resolved
justinmk3
reviewed
Nov 12, 2024
packages/core/src/test/applicationcomposer/messageHandlers/generateResourceHandler.test.ts
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
Nov 12, 2024
justinmk3
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See issue: #5970
Solution
appears to be similar to #5955, so same solution is employed.
skipIfVscodeBelowfor tests that are flaky on previous versions.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.