-
Notifications
You must be signed in to change notification settings - Fork 734
test(appcomposer): fix initMessageHandler flaky test. #5973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f547690
focus on flaky test
Hweinstock a3731c4
skip test on minimum
Hweinstock af2bffb
Merge branch 'master' into appComposer/flakyTest
Hweinstock a12730e
factor out shared logic into utility function
Hweinstock 14fba92
rename param
Hweinstock fc6cc6c
refactor shared method to be clearer
Hweinstock 89abb72
redo change
Hweinstock 1e88ae5
redo change pt2
Hweinstock a0b1704
Merge branch 'master' into appComposer/flakyTest
Hweinstock c21e013
refactor shared logic into another helper
Hweinstock 19b7b2c
move afterEach back
Hweinstock 67e6838
Merge branch 'master' into appComposer/flakyTest
Hweinstock 068241a
use dict version of isMinVscode
Hweinstock 9d14980
make options an optional param
Hweinstock 49c8e43
Merge branch 'master' into appComposer/flakyTest
Hweinstock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.