test: update /dev prepareRepoData unit test to include devfile filtering #5980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyyhuang
force-pushed
the
wlsun/update-devfile-flow-test
branch
from
8d4bad4 to
42f0bb6
Compare
packages/amazonq/test/unit/amazonqFeatureDev/util/files.test.ts
Outdated
Show resolved
Hide resolved
packages/amazonq/test/unit/amazonqFeatureDev/util/files.test.ts
Outdated
Show resolved
Hide resolved
packages/amazonq/test/unit/amazonqFeatureDev/util/files.test.ts
Outdated
Show resolved
Hide resolved
willyyhuang
force-pushed
the
wlsun/update-devfile-flow-test
branch
from
42f0bb6 to
4563f1c
Compare
chengoramazon
approved these changes
Nov 13, 2024
packages/amazonq/test/unit/amazonqFeatureDev/util/files.test.ts
Outdated
Show resolved
Hide resolved
willyyhuang
force-pushed
the
wlsun/update-devfile-flow-test
branch
from
4563f1c to
6c28506
Compare
packages/amazonq/test/unit/amazonqFeatureDev/util/files.test.ts
Outdated
Show resolved
Hide resolved
willyyhuang
force-pushed
the
wlsun/update-devfile-flow-test
branch
from
6c28506 to
996625c
Compare
jpinkney-aws
approved these changes
Nov 14, 2024
Contributor
|
Looks like |
Contributor
Author
taking a look |
Contributor
Author
|
this was the error: TypeError: Attempted to wrap getDevCommandWorkspaceConfigurations which is already wrapped will add a sinon.restore in afterEach hook to reset the mocks |
willyyhuang
force-pushed
the
wlsun/update-devfile-flow-test
branch
from
996625c to
38771f8
Compare
packages/amazonq/test/unit/amazonqFeatureDev/util/files.test.ts
Outdated
Show resolved
Hide resolved
willyyhuang
force-pushed
the
wlsun/update-devfile-flow-test
branch
from
38771f8 to
f3ecb62
Compare
jpinkney-aws
approved these changes
Nov 14, 2024
jpinkney-aws
merged commit ac76171
into
aws:feature/q-dev-execution
22 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow up PR from #5853
Solution
Added more unit test coverage
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.