fix(cwl): LiveTail fails to start when clicking with Play next to a LogGroup #5986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from Explorer. Rename LogGroupName to LogGroupArn in LiveTail
This comment was marked as resolved.
This comment was marked as resolved.
justinmk3
changed the title
justinmk3
changed the title
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
…ogGroup aws#5986 ## Problem Starting a LiveTail session by clicking Play next to a specific LogGroup in the explorer menu is failing. This is because the LogGroup name is passed into the Wizard response, and not a fully qualified Arn. StartLiveTail API request requires ARNs. ## Solution Detect if the context when initializing the TailLogGroup wizard is a LogGroup Name or Arn. If it is just a name, construct the Arn and set that in the Wizard response. Renames `LogGroupName` in `LiveTailSession` to `LogGroupArn` to make it more clear what is expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Starting a LiveTail session by clicking Play next to a specific LogGroup in the explorer menu is failing. This is because the LogGroup name is passed into the Wizard response, and not a fully qualified Arn.
StartLiveTail API request requires ARNs.
Solution
Detect if the context when initializing the TailLogGroup wizard is a LogGroup Name or Arn. If it is just a name, construct the Arn and set that in the Wizard response.
Renames
LogGroupNameinLiveTailSessiontoLogGroupArnto make it more clear what is expected.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.