Skip to content

Conversation

@keeganirby
Copy link
Contributor

Problem

Currently after closing a session in a way that leaves the TextDocument open (Stop tailing CodeLens), the codeLenses remain visible. This means a user could click Stop tailing again, and receive an error for not being able to find the running LiveTail session for the given document.

Additionally, there is no feedback when a session is closed. Clicking Stop tailing doesn't signal to the user that the session was actually stopped.

Solution

  • Provide a refresh method in the LiveTail CodeLens provider. This fires an event to force recomputing the CodeLenses on a document.
  • Modify LiveTail Lens provider to return no Lenses if the session is not running (in the registry)
  • Display an information window when a Session is stopped
  • Changes wording/placement on some log statements for consistency.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@keeganirby keeganirby requested a review from a team as a code owner November 20, 2024 18:24
@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jpinkney-aws jpinkney-aws merged commit aceebe1 into aws:feature/cwltail Nov 20, 2024
23 of 25 checks passed
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
…ing session (aws#6063)

## Problem
Currently after closing a session in a way that leaves the TextDocument
open (`Stop tailing` CodeLens), the codeLenses remain visible. This
means a user could click `Stop tailing` again, and receive an error for
not being able to find the running LiveTail session for the given
document.

Additionally, there is no feedback when a session is closed. Clicking
`Stop tailing` doesn't signal to the user that the session was actually
stopped.

## Solution
* Provide a `refresh` method in the LiveTail CodeLens provider. This
fires an event to force recomputing the CodeLenses on a document.
* Modify LiveTail Lens provider to return no Lenses if the session is
not running (in the registry)
* Display an information window when a Session is stopped
* Changes wording/placement on some log statements for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants