-
Notifications
You must be signed in to change notification settings - Fork 733
deps(sdkv3): start migration to v3 with new client builder #6097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(sdkv3): start migration to v3 with new client builder #6097
Conversation
4dbd3b4 to
89ef745
Compare
justinmk3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're here let's rename packages/core/src/test/shared/defaultAwsClientBuilder.test.ts to awsClientBuilder.test.ts
| reasonDesc: getTelemetryReasonDesc(err), | ||
| reason: getTelemetryReason(err), | ||
| result: getTelemetryResult(err), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old awsClientBuilder.ts was reluctant to set these fields. But I think setting them here is low-risk and potentially adds useful info:
- if the caller is wrapped in
telemetry.xx.run()then these fields will be overridden by the run() context finalizer anyway - else, these fields give some useful info
todo: Maybe the run() finalizer logic should be smarter and check if there was a SDK failure (these fields)?
Problem
Start the transition to sdkv3. This PR is just a start and is still missing a lot of features (see future work).
Originally part of #5940, but decided to split it up.
Solution
Future Work
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.