ci(run_and_report): remove workaround for vscode 1.68 #6121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpinkney-aws
approved these changes
Dec 3, 2024
Contributor
jpinkney-aws
left a comment
jpinkney-aws
left a comment
There was a problem hiding this comment.
I don't have context as to why that was ever needed but if it was happening on such a long release we should be good now
justinmk3
changed the title
justinmk3
changed the title
avi-alpert
pushed a commit
to avi-alpert/aws-toolkit-vscode
that referenced
this pull request
Dec 4, 2024
## Problem Ignore pattern that is only needed on the vscode minimum version of 1.68, but we have bumped to 1.83.0. ## Solution Remove pattern for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
According to the comment in this file, there is an ignore pattern that is only needed on the vscode minimum version of 1.68, but we have bumped to 1.83.0.
Solution
Remove pattern for this case.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.