Skip to content

ci(run_and_report): remove workaround for vscode 1.68 #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

ci(run_and_report): remove workaround for vscode 1.68 #6121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions buildspec/shared/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,9 @@

# Ignore these patterns when deciding if the build should fail.
# - "waiting for browser": from `ssoAccessTokenProvider.test.ts`, unclear how to fix it.
# - "Webview is disposed": only happens on vscode "minimum" (1.68.0)
# - "HTTPError: Response code …": caused by github rate-limiting.
# - "npm WARN deprecated querystring": transitive dep of aws sdk v2 (check `npm ls querystring`), so that's blocked until we migrate to v3.
_ignore_pat='Timed-out waiting for browser login flow\|HTTPError: Response code 403\|HTTPError: Response code 404\|npm WARN deprecated querystring\|npm WARN deprecated'
if [ "$VSCODE_TEST_VERSION" = 'minimum' ]; then
_ignore_pat="$_ignore_pat"'\|Webview is disposed'
fi

# Do not print (noisy) lines matching these patterns.
# - "ERROR:bus… Failed to connect to the bus": noise related to "xvfb". https://github.com/cypress-io/cypress/issues/19299
Expand Down
Loading