Skip to content

Conversation

@ntarakad-aws
Copy link
Contributor

Problem

For selective transformation, the first patch is a minimal upgrade to java 17. We provide descriptions of all of these in the chat. However, if the source java version detected is "Java 17", then we don't want to show the minimal java 17 patch description to the user.

Solution

Instead, we will case on what the java source version was detected to be. If it is java 17, we will not show the first patch description message. Otherwise, we will show this message.


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ntarakad-aws ntarakad-aws self-assigned this Dec 3, 2024
@ntarakad-aws ntarakad-aws requested review from a team as code owners December 3, 2024 18:37
@github-actions
Copy link

github-actions bot commented Dec 3, 2024

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@dhasani23 dhasani23 marked this pull request as draft December 3, 2024 19:22
@dhasani23 dhasani23 closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants