Skip to content

feat(toolkit): Upgrade amazon-states-language-service to 1.13.0 #6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2024
Merged

feat(toolkit): Upgrade amazon-states-language-service to 1.13.0 #6139

merged 3 commits into from
Dec 4, 2024

Conversation

@elvin-hwang
Copy link
Contributor

@elvin-hwang elvin-hwang commented Dec 3, 2024

Upgrading amazon-states-language-service from 1.11.0 to 1.13.0

@elvin-hwang elvin-hwang requested a review from a team as a code owner December 3, 2024 23:59
@elvin-hwang elvin-hwang changed the title Upgrade amazon-states-language-service to 1.13.0 feat: Upgrade amazon-states-language-service to 1.13.0 Dec 4, 2024
@elvin-hwang elvin-hwang changed the title feat: Upgrade amazon-states-language-service to 1.13.0 feat(toolkit): Upgrade amazon-states-language-service to 1.13.0 Dec 4, 2024
@justinmk3 justinmk3 changed the base branch from master to feature/postreinvent December 4, 2024 00:42
@justinmk3
Copy link
Contributor

justinmk3 commented Dec 4, 2024

which issues are related?

@elvin-hwang
Copy link
Contributor Author

elvin-hwang commented Dec 4, 2024

which issues are related?

#6118
aws/amazon-states-language-service#159
aws/amazon-states-language-service#160

@justinmk3 justinmk3 merged commit 59acbc6 into aws:feature/postreinvent Dec 4, 2024
10 of 16 checks passed
@elvin-hwang elvin-hwang deleted the upgrade_asl_minor_version branch December 4, 2024 17:57
@justinmk3
Copy link
Contributor

justinmk3 commented Dec 7, 2024

Integ tests are failing after this PR

1 failing
  1) stepFunctions ASL LSP
       init:

      AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected ... Lines skipped

  [
    'Comment',
+   'QueryLanguage',
    'StartAt',
...
    'TimeoutSeconds',
    'Version'
  ]
      + expected - actual

       [
         "Comment"
      -  "QueryLanguage"
         "StartAt"
         "States"
         "TimeoutSeconds"
         "Version"
      
      at Context.<anonymous> (/codebuild/output/src2587939618/src/github.com/aws/aws-toolkit-vscode/packages/core/src/testInteg/stepFunctions/init.test.ts:36:16)

@witness-me witness-me mentioned this pull request Dec 9, 2024
Merged
justinmk3 pushed a commit that referenced this pull request Dec 9, 2024
@witness-me
test(stepfunctions): failing integration test after ASL update #6188
7cefa67 
## Problem
Integration test for SFN was broken after updating
amazon-states-language-service package to 1.13.0 ([relevant
PR](#6139))

## Solution
Updating integration test to account for the new `QueryLanguage`
variable introduced in the new version of the package
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
@elvin-hwang @karanA-aws
feat(toolkit): Upgrade amazon-states-language-service to 1.13.0 aws#6139
d7e5080 


ref aws#6118
ref aws/amazon-states-language-service#159
ref aws/amazon-states-language-service#160
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
@witness-me @karanA-aws
test(stepfunctions): failing integration test after ASL update aws#6188
01074bd 
## Problem
Integration test for SFN was broken after updating
amazon-states-language-service package to 1.13.0 ([relevant
PR](aws#6139))

## Solution
Updating integration test to account for the new `QueryLanguage`
variable introduced in the new version of the package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@justinmk3 justinmk3 justinmk3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elvin-hwang @justinmk3