Skip to content

Conversation

@justinmk3
Copy link
Contributor

Problem

codecov always fails for gumby/appcomposer:

codecov/project/amazonqGumby — 75.29% (-3.93%)
codecov/project/applicationcomposer — 82.69% (-0.…)

Based on https://docs.codecov.com/docs/commit-status , the "default" item is just a name, it doesn't set defaults that are "inherited".

Solution

  • rename the "default" project item to avoid confusion
  • duplicate the configuration for all project items.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem:
codecov always fails for gumby/appcomposer:

    codecov/project/amazonqGumby — 75.29% (-3.93%)
    codecov/project/applicationcomposer — 82.69% (-0.…)

Based on https://docs.codecov.com/docs/commit-status , the "default"
item is just a name, it doesn't set defaults that are "inherited".

Solution:
- rename the "default" project item to avoid confusion
- duplicate the configuration for all project items.
@justinmk3 justinmk3 requested a review from a team as a code owner December 4, 2024 20:08
@justinmk3 justinmk3 merged commit d74f96c into aws:master Dec 4, 2024
16 checks passed
@justinmk3 justinmk3 deleted the fixcodecov branch December 4, 2024 20:22
laileni-aws pushed a commit to laileni-aws/aws-toolkit-vscode that referenced this pull request Dec 6, 2024
## Problem
codecov always fails for gumby/appcomposer:

    codecov/project/amazonqGumby — 75.29% (-3.93%)
    codecov/project/applicationcomposer — 82.69% (-0.…)

Based on https://docs.codecov.com/docs/commit-status , the "default"
item is just a name, it doesn't set defaults that are "inherited".

## Solution
- rename the "default" project item to avoid confusion
- duplicate the configuration for all project items.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants