Skip to content

Conversation

@avi-alpert
Copy link
Contributor

Problem

When a user clicks the "Change folder" button when creating or updating a README, the "Generating answer..." loading text appears, even though there is no answer being generated, since we are waiting for the user to choose a folder.

This is an especially confusing UX if the user is connected to an SSH host:
Existing UX

Solution

When the user clicks the "Change folder" button, send a "Choose a folder to continue" message in the chat.

Fix


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@avi-alpert avi-alpert requested a review from a team as a code owner December 5, 2024 18:08
@github-actions
Copy link

github-actions bot commented Dec 5, 2024

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs review from a Q team member.

Is this required for this week's release or can it wait until next week?

@avi-alpert
Copy link
Contributor Author

This can wait till next week. Should i change the target branch if it can wait?

@justinmk3 justinmk3 changed the base branch from master to feature/postreinvent December 5, 2024 19:26
@justinmk3 justinmk3 merged commit 83aac85 into aws:feature/postreinvent Dec 5, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants