Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

Problem

  • the current implementation only opens the first tab as a welcome tab for the next 3 times you open vscode

Solution

  • the new implementation shows the welcome tab 3 total times, either when you open a new chat tab or a new vscode window or both

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem:
- the current implementation only opens the first tab as a welcome tab for the next 3 times you open vscode

Solution:
- the new implementation shows the welcome tab 3 times, either when you open a new chat tab or a new vscode window or both
@jpinkney-aws jpinkney-aws requested review from a team as code owners December 6, 2024 13:06
@github-actions
Copy link

github-actions bot commented Dec 6, 2024

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@jpinkney-aws jpinkney-aws merged commit 34bc67e into aws:master Dec 13, 2024
26 checks passed
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
## Problem
- the current implementation only opens the first tab as a welcome tab
for the next 3 times you open vscode

## Solution
- the new implementation shows the welcome tab 3 total times, either
when you open a new chat tab or a new vscode window or both

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).

License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants