telemetry(amazonq): UTG sends plaintext instead of python for amazonq_utgGenerateTests event #6174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hayemaxi
reviewed
Dec 6, 2024
| generatedLinesCount: session.linesOfCodeGenerated, | ||
| acceptedLinesCount: session.linesOfCodeAccepted, | ||
| cwsprChatProgrammingLanguage: session.fileLanguage, | ||
| cwsprChatProgrammingLanguage: session.fileLanguage ?? 'plaintext', |
Contributor
There was a problem hiding this comment.
Is this the proper place to put this default? Will other functions also default to plaintext? If so, initialize in a common place.
Contributor
Author
There was a problem hiding this comment.
@chungjac is working on this.
We aim to declare the telemetry function in telemetryHelper.ts and use it here but for now fixing this here.
hayemaxi
approved these changes
Dec 6, 2024
ashishrp-aws
approved these changes
Dec 6, 2024
ctlai95
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
session.fileLanguage = await this.getLanguageForFilePath(filePath)reassigned python to plaintext after test generation.Solution
session.fileLanguage = await this.getLanguageForFilePath(filePath)should fix the issue.feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.