Skip to content

Conversation

@ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented Dec 9, 2024

Problem

Applying a fix does not update the position of other issues in the same file.

Solution

Revert disabling event handler on apply fix command


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Dec 9, 2024

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@ctlai95 ctlai95 marked this pull request as ready for review December 9, 2024 23:17
@ctlai95 ctlai95 requested review from a team as code owners December 9, 2024 23:17
Copy link
Contributor

@jpinkney-aws jpinkney-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can craft a test for this? Otherwise please have a team mate review your code

@ctlai95 ctlai95 requested a review from jpinkney-aws December 10, 2024 17:10
@justinmk3 justinmk3 merged commit ef926e4 into aws:master Dec 10, 2024
26 of 27 checks passed
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
## Problem
Applying a fix does not update the position of other issues in the same
file.

## Solution
Revert disabling event handler on apply fix command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants