-
Notifications
You must be signed in to change notification settings - Fork 751
test(core): merge all package test reports #6261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 14 commits
0b2aed9
081c031
5ef73cf
dfe2892
5273b20
5b6e145
adf5ca6
4e5655f
bb0bf30
b7e94e0
9d89d5b
155f4c5
d03a757
924b90e
5d3ade7
9a6f7b7
28384ad
a5f44d8
e7d26cb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -41,7 +41,7 @@ phases: | |||||
| # Ensure that "foo | run_and_report" fails correctly. | ||||||
| set -o pipefail | ||||||
| . buildspec/shared/common.sh | ||||||
| 2>&1 xvfb-run npm test --silent | run_and_report 2 \ | ||||||
| 2>&1 xvfb-run npm test --silent; PREVIOUS_TEST_EXIT_CODE=$? npm run mergeReports | run_and_report 2 \ | ||||||
| 'rejected promise not handled' \ | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Based on a local test of this command: I suspect the above To confirm that the piping to
Suggested change
then CI should fail. If it doesn't, we can fix the issue by changing the pipeline to something like (note: whitespace near the braces is required):
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just tested and that was indeed the case. I've switched to your suggestion and it seems to work as expected |
||||||
| 'This typically indicates a bug. Read https://developer.mozilla.org/docs/Web/JavaScript/Guide/Using_promises#error_handling' | ||||||
| } | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| /*! | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import * as fs from 'fs' | ||
| import * as path from 'path' | ||
| import * as xml2js from 'xml2js' | ||
|
|
||
| /** | ||
| * Merge all of the packages/ test reports into a single directory | ||
| */ | ||
| async function mergeReports() { | ||
| console.log('Merging test reports') | ||
|
|
||
| const packagesDir = path.join(__dirname, '..', 'packages') | ||
jpinkney-aws marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| // Get all packages/* directories | ||
| const packageDirs = fs.readdirSync(packagesDir).map((dir) => path.join(packagesDir, dir)) | ||
|
|
||
| // Find report.xml files in .test-reports subdirectories | ||
| const testReports = packageDirs | ||
| .map((dir) => path.join(dir, '.test-reports', 'report.xml')) | ||
jpinkney-aws marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| .filter((file) => fs.existsSync(file)) | ||
|
|
||
| const mergedReport = { | ||
| testsuites: { | ||
| testsuite: [], | ||
| }, | ||
| } | ||
|
|
||
| // Collect all test reports into a single merged test report object | ||
| for (const file of testReports) { | ||
| const content = fs.readFileSync(file) | ||
| const result: { testsuites: { testsuite: [] } } = await xml2js.parseStringPromise(content) | ||
| if (result.testsuites && result.testsuites.testsuite) { | ||
| mergedReport.testsuites.testsuite.push(...result.testsuites.testsuite) | ||
| } | ||
| } | ||
|
|
||
| const builder = new xml2js.Builder() | ||
| const xml = builder.buildObject(mergedReport) | ||
|
|
||
| /** | ||
| * Create the new test reports directory and write the test report | ||
| */ | ||
| const reportsDir = path.join(__dirname, '..', '.test-reports') | ||
jpinkney-aws marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // Create reports directory if it doesn't exist | ||
| if (!fs.existsSync(reportsDir)) { | ||
| fs.mkdirSync(reportsDir, { recursive: true }) | ||
| } | ||
|
|
||
| fs.writeFileSync(path.join(reportsDir, 'report.xml'), xml) | ||
|
|
||
| /** | ||
| * Retrieves the exit code from the previous test run execution. | ||
| * | ||
| * This allows us to: | ||
| * 1. Merge and upload test reports regardless of the test execution status | ||
| * 2. Preserve the original test run exit code | ||
| * 3. Report the test status back to CI | ||
| */ | ||
| const exitCode = parseInt(process.env.PREVIOUS_TEST_EXIT_CODE || '0', 10) | ||
| process.exit(exitCode) | ||
| } | ||
|
|
||
| mergeReports() | ||
Uh oh!
There was an error while loading. Please reload this page.