telemetry(amazonq): add metric for transformation type #6284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added 2 commits
December 20, 2024 23:47
dhasani23
changed the title
ntarakad-aws
approved these changes
Dec 23, 2024
justinmk3
reviewed
Dec 23, 2024
| await this.messenger.sendSelectSQLMetadataFileMessage(message.tabID) | ||
| } | ||
| } catch (err: any) { | ||
| getLogger().error(`Error handling SQL conversion: ${err}`) |
Contributor
There was a problem hiding this comment.
Note: if the exception is caught then run() won't reflect a result=Failed.
If handleSQLConversion is called from a command or webview, the extension global handler will log the error and show a useful message to the user. If not, then the next best approach is to let the exception through, but add .catch(...) to the run() call.
Same for the other case in this PR.
hayemaxi
approved these changes
Dec 31, 2024
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem Be able to tell when a language upgrade vs sql conversion happens. ## Solution Add metric. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: David Hasani <[email protected]>
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem Be able to tell when a language upgrade vs sql conversion happens. ## Solution Add metric. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: David Hasani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Be able to tell when a language upgrade vs sql conversion happens.
Solution
Add metric.
feature/xbranches will not be squash-merged at release time.