fix(amazonq): Include mvn and gradle files in repo archives #6300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
osdemah
changed the title
osdemah
changed the title
neilk-aws
approved these changes
Jan 3, 2025
justinmk3
reviewed
Jan 3, 2025
packages/amazonq/.changes/next-release/Bug Fix-993929aa-5dd5-440a-9150-8ae5ba5f56ac.json
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
Jan 3, 2025
| return true | ||
| } | ||
| for (const subname of wellKnownSubnames) { | ||
| if (filename.includes(subname)) { |
Contributor
There was a problem hiding this comment.
this is a very loose check.
surely these changes deserve a test...
Contributor
Author
There was a problem hiding this comment.
this implicitness was intentional, as I wouldn't want to chase down specific extensions/file names for them. but we could also just include the missing file names and extensions. updated to the latter and added some tests.
Contributor
|
LGTM after lint issues are fixed |
Contributor
|
merging latest master (again) will fix the "tech debt" test failure. there are still lint issues that need to be fixed here. |
justinmk3
approved these changes
Jan 7, 2025
Contributor
|
@osdemah E2E and Integ tests are failing after merging this (I forgot to run them for this PR). |
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem mvn and gradle files are not included in repo archives for Q. ## Solution Add them to the `isCodeFile()` condition.
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem mvn and gradle files are not included in repo archives for Q. ## Solution Add them to the `isCodeFile()` condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
mvn and gradle files are not included in repo archives for Q.
Solution
Add a
wellKnownSubnameslist to include files withmvnandgradlein their path.feature/xbranches will not be squash-merged at release time.