revert: old codepaths from session separation/standalone #6306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
approved these changes
Jan 6, 2025
jpinkney-aws
approved these changes
Jan 6, 2025
Removes code that should no longer be necessary anymore.
- Remove autoinstall Amazon Q if you were a CodeWhisperer user on 2.x versions of toolkit
- The prompt to install Amazon Q will still appear, if you don't have it. It has been slightly reworded.
- If Amazon Q is installed, then you uninstall, it you will not see the prompt again in toolkit (previously you could).
- Remove settings migrations from codewhisperer settings
- Remove amazon Q telemetry enabled setting being initialized by the value from toolkit.
We are still getting hits in telemetry for people getting auto install (172 in last 2 months). However, they are mostly on old versions.
Let's simplyify our codebase by removing support for these dated codepaths.
Removes the prompt shown in Toolkit that Amazon Q no longer shares connections with it. Some time has passed, active users should have been informed by now. We are still getting telemetry hits indicating that this is being used though. NOTE: Does not revert or remove any separation logic itself. We continue to have separate sessions and also remove any connections in either extension that are extra or don't match the required scopes for that extension. That logic helps us catch auth edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert: amazon q standalone special handling
Removes code that should no longer be necessary anymore.
We are still getting hits in telemetry for people getting auto install (172 in last 2 months). However, they are mostly on old versions.
Let's simplify our codebase by removing support for these dated codepaths.
revert(toolkit): Q <--> Toolkit auth separation notification
Removes the prompt shown in Toolkit that Amazon Q no longer shares connections with it. Some time has passed, active users should have been informed by now. We are still getting telemetry hits indicating that this is being used though.
NOTE: Does not revert or remove any separation logic itself. We continue to have separate sessions and also remove any connections in either extension that are extra or don't match the required scopes for that extension. That logic helps us catch auth edge cases.
feature/xbranches will not be squash-merged at release time.